RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

[David Holmes]

On Thu, 20 Oct 2022 07:14:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>>  - Also javaClasses.cpp
>>  - Fix
>
> Thanks!

@shipilev  this has broken our linux aarch64 builds!

[2022-10-20T07:26:59,542Z] workspace/open/src/hotspot/cpu/aarch64/assembler_aarch64.cpp: In member function 'void Address::lea(MacroAssembler*, Register) const':
[2022-10-20T07:26:59,542Z] workspace/open/src/hotspot/cpu/aarch64/assembler_aarch64.cpp:138:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation]
[2022-10-20T07:26:59,542Z]   138 |     else
[2022-10-20T07:26:59,542Z]       |     ^~~~
[2022-10-20T07:26:59,542Z] workspace/open/src/hotspot/cpu/aarch64/assembler_aarch64.cpp:140:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
[2022-10-20T07:26:59,542Z]   140 |       break;
[2022-10-20T07:26:59,542Z]       |       ^~~~~

-------------

PR: https://git.openjdk.org/jdk/pull/10444