RFR: 8293769: RISC-V: Add a second temporary register for BarrierSetAssembler::load_at
Aleksey Shipilev
shade at openjdk.org
Wed Sep 14 06:43:35 UTC 2022
On Wed, 14 Sep 2022 03:09:16 GMT, Fei Yang <fyang at openjdk.org> wrote:
> This is similar to https://bugs.openjdk.org/browse/JDK-8293351
> Add a second temporary register for BarrierSetAssembler::load_at GC API on riscv64.
> Today G1 and Shenandoah uses a second temporary register. This will also be the case for generational ZGC.
>
> Testing: Tier1-3 tested on Linux-riscv64 SiFive Unmatched board.
Looks fine, but I have a question.
src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.cpp line 318:
> 316: __ push_call_clobbered_registers();
> 317:
> 318: satb_write_barrier_pre(masm, noreg, dst, xthread, tmp, t0, true, false);
Is `tmp` not `t0` here? I expected to see `t1` in this diff. Maybe I am missing something.
-------------
PR: https://git.openjdk.org/jdk/pull/10261
More information about the shenandoah-dev
mailing list