RFR: Cleanups, TODOs, asserts (part 1) [v5]

[Y. Srinivas Ramakrishna]

On Mon, 10 Apr 2023 18:10:52 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I have been reading the `openjdk/shenandoah` vs `openjdk/jdk` diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - Merge branch 'master' into upstream-cleanup-1
>  - Refine TODO
>  - Remove unnecessary comment
>  - Fix a little indentation error
>  - New assert fires, but instead of fixing it, remove useless live_memory completely
>  - Reverse bad fix
>  - More fixes
>  - More work
>  - More improvements
>  - More touchups
>  - ... and 5 more: https://git.openjdk.org/shenandoah/compare/461f0831...c0af0d7e

A few comments, but overall looks good; thanks fo the clean-ups (and marking future clean-ups).

src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp line 400:

> 398: 
> 399:   // Like oop_fill_and_coalesce(), but without honoring cancellation requests.
> 400:   bool oop_fill_and_coalesce_without_cancel();

Along similar lines, not sure if you also got `register_object_wo_lock` in this round of cleanups.

-------------

Marked as reviewed by ysr (Author).

PR Review: https://git.openjdk.org/shenandoah/pull/245#pullrequestreview-1378247197
PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1162164699