RFR: Cleanups, TODOs, asserts (part 1) [v5]

[Aleksey Shipilev]

On Mon, 10 Apr 2023 23:24:30 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 59:
>> 
>>> 57: const double ShenandoahAdaptiveHeuristics::MAXIMUM_CONFIDENCE = 3.291; // 99.9%
>>> 58: 
>>> 59: // TODO: Provide comment here or remove if not used
>> 
>> currently used at: https://github.com/openjdk/shenandoah/blob/c0af0d7e04174b2d149c0e5b8c37e3454215ad20/src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp#L468
>
> Some of these may potentially want to be global tunables; may be...

Yes, but Kelvin says the upcoming PR might eliminate the uses. So I added a reminder.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1162421581