RFR: Cleanups, TODOs, asserts (part 1) [v5]

[Y. Srinivas Ramakrishna]

On Mon, 10 Apr 2023 23:20:42 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge branch 'master' into upstream-cleanup-1
>>  - Refine TODO
>>  - Remove unnecessary comment
>>  - Fix a little indentation error
>>  - New assert fires, but instead of fixing it, remove useless live_memory completely
>>  - Reverse bad fix
>>  - More fixes
>>  - More work
>>  - More improvements
>>  - More touchups
>>  - ... and 5 more: https://git.openjdk.org/shenandoah/compare/461f0831...c0af0d7e
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 59:
> 
>> 57: const double ShenandoahAdaptiveHeuristics::MAXIMUM_CONFIDENCE = 3.291; // 99.9%
>> 58: 
>> 59: // TODO: Provide comment here or remove if not used
> 
> currently used at: https://github.com/openjdk/shenandoah/blob/c0af0d7e04174b2d149c0e5b8c37e3454215ad20/src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp#L468

Some of these may potentially want to be global tunables; may be...

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1162163702