RFR: Cleanups, TODOs, asserts (part 2)

[Aleksey Shipilev]

On Wed, 12 Apr 2023 03:19:28 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>>  - [x] GHA builds
>
> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 149:
> 
>> 147:               "oop must be aligned");
>> 148: 
>> 149:     ShenandoahHeapRegion *obj_reg = _heap->heap_region_containing(obj);
> 
> Stet. Looks like this change should not be made, nor the ones below marked "Ditto".

It reduces the difference against upstream, which would simplify a lot of things, including backporting. Yes, I know it reverses the hygienic fix here, but I draw the line at having these changes as the _only_ changes in the relevant patch hunk. See here, for example: https://builds.shipilev.net/patch-openjdk-shenandoah/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp.sdiff.html

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1163823238