RFR: Cleanups, TODOs, asserts (part 2) [v2]

[Y. Srinivas Ramakrishna]

On Wed, 12 Apr 2023 08:49:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 149:
>> 
>>> 147:               "oop must be aligned");
>>> 148: 
>>> 149:     ShenandoahHeapRegion *obj_reg = _heap->heap_region_containing(obj);
>> 
>> Stet. Looks like this change should not be made, nor the ones below marked "Ditto".
>
> It reduces the difference against upstream, which would simplify a lot of things, including backporting. Yes, I know it reverses the hygienic fix here, but I draw the line at having these changes as the _only_ changes in the relevant patch hunk. See here, for example: https://builds.shipilev.net/patch-openjdk-shenandoah/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp.sdiff.html

It looks like you have a plan for how to address these and previous remarks. I'll go ahead and mark as reviewed!

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1164753224