RFR: Cleanups, TODOs, asserts (part 2) [v2]

[Aleksey Shipilev]

On Wed, 12 Apr 2023 17:57:22 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - More review comments
>>  - Move and rename remset verifications
>>  - Review Ramki
>
> src/hotspot/share/gc/shenandoah/shenandoahMark.inline.hpp line 291:
> 
>> 289:       mark_ref(q, mark_context, weak, obj);
>> 290:       shenandoah_assert_marked(p, obj);
>> 291:       // TODO: This is v-call on very hot path, can we sense the same from GENERATION?
> 
> Maybe if there was a ShenandoahGenerationType that distinguished single-gen from the generational modes..  Agree we would like to template-resolve this path.

Yes, let me look at that separately.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1165183449