RFR: Cleanups, TODOs, asserts (part 2)

[Kelvin Nilsen]

On Tue, 11 Apr 2023 15:00:19 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
> 
> Additional testing:
>  - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>  - [x] GHA builds

Looks good as long as it introduces no correctness regressions on the Generational Shenandoah test pipelines.

src/hotspot/share/gc/shenandoah/shenandoahMark.inline.hpp line 291:

> 289:       mark_ref(q, mark_context, weak, obj);
> 290:       shenandoah_assert_marked(p, obj);
> 291:       // TODO: This is v-call on very hot path, can we sense the same from GENERATION?

Maybe if there was a ShenandoahGenerationType that distinguished single-gen from the generational modes..  Agree we would like to template-resolve this path.

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/252#pullrequestreview-1381834773
PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1164469043