RFR: JDK-8314777: GenShen: Alias young and old marking bits to legacy Shenandoah marking bit in gc state [v2]

William Kemper wkemper at openjdk.org
Tue Aug 22 23:57:47 UTC 2023


On Tue, 22 Aug 2023 20:47:47 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> This change sets the MARKING bit of _gc_state whenever either Young marking or Old marking is active.  With this change, barrier code more closely resembles the code in the original single-generation Shenandoah.  The performance impact is negligible.  The primary benefit is to simplify code reviews and clarify that the addition of generational mode to Shenandoah does not negatively impact performance of single-generation Shenandoah.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tidy up asserts

Marked as reviewed by wkemper (Committer).

Looks like new assert is causing build problems and test failures.

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/309#pullrequestreview-1590497751
Changes requested by wkemper (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/309#pullrequestreview-1590499434


More information about the shenandoah-dev mailing list