RFR: JDK-8314777: GenShen: Alias young and old marking bits to legacy Shenandoah marking bit in gc state [v2]

[Kelvin Nilsen]

On Tue, 22 Aug 2023 21:54:57 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tidy up asserts
>
> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 842:
> 
>> 840:              ((actual & ShenandoahHeap::MARKING) && (actual & (ShenandoahHeap::YOUNG_MARKING | ShenandoahHeap::OLD_MARKING))),
>> 841:              "Inconsistent gc marking state");
>> 842: 
> 
> Would this read easier?
> 
> 
> #ifdef ASSERT
>     const ShenandoahSharedValue val = actual & (MARKING|YOUNG_MARKING|OLD_MARKING);
>     assert((val & MARKING) == ((val & YOUNG_MARKING) || (val & OLD_MARKING)), "Error");
> #endif

Thanks.  I like this improvement, slightly refined.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/309#discussion_r1303131797