RFR: JDK-8315279: Factor 'basic_plus_adr' out of PhaseMacroExpand and delete make_load/store

[Vladimir Kozlov]

On Wed, 30 Aug 2023 03:13:08 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

> I believe the factory methods for AddPNode should be in the AddPNode class. The make_load / make_store methods in PhaseMacroExpand can be refactored to instead just use the "make" methods from Load/Store classes.
> 
> Tested with tier1-3.

Good cleanup.
My only suggestion is to keep `AddPNode::make()` and `PhaseValues::makecon()` in header files .hpp - they are small and no need to put to .cpp files.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15480#pullrequestreview-1603482700