RFR: JDK-8315279: Factor 'basic_plus_adr' out of PhaseMacroExpand and delete make_load/store [v2]

[Cesar Soares Lucas]

> I believe the factory methods for AddPNode should be in the AddPNode class. The make_load / make_store methods in PhaseMacroExpand can be refactored to instead just use the "make" methods from Load/Store classes.
> 
> Tested with tier1-3.

Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:

  move definitions to hpp files

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15480/files
  - new: https://git.openjdk.org/jdk/pull/15480/files/776b202c..5d988b01

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15480&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15480&range=00-01

  Stats: 42 lines in 4 files changed: 13 ins; 24 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/15480.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15480/head:pull/15480

PR: https://git.openjdk.org/jdk/pull/15480