RFR: JDK-8315279: Factor 'basic_plus_adr' out of PhaseMacroExpand and delete make_load/store [v3]

[Cesar Soares Lucas]

On Thu, 31 Aug 2023 20:42:39 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Thanks for clarifying @iwanowww . I think I see your point now. My original intent was to just move these methods out of PhaseMacroExpand and not much else. 
>> 
>> I'm going to do some more refactoring and patch all users of these make methods to just use this single method: `static Node* make(PhaseIterGVN& igvn, Node* base, Node* ptr, Node* offset)`. What do you think?
>
> Sounds good. 
> 
> But in the future I'd like to see `PhaseMacroExpand` and `PhaseIdealLoop` migrated to `GraphKit` instead.

Actually, I think it's silly to create a method to just do a "return ... new AddP":

static Node* make(PhaseIterGVN& igvn, Node* base, Node* ptr, Node* offset) {
    return igvn.register_new_node_with_optimizer(new AddPNode(base, ptr, offset));
}

I can just replace the uses of this `make` with a `new AddP...`.

> But in the future I'd like to see PhaseMacroExpand and PhaseIdealLoop migrated to GraphKit instead.

Roger that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15480#discussion_r1312299405