RFR: JDK-8315279: Factor 'basic_plus_adr' out of PhaseMacroExpand and delete make_load/store [v4]
Cesar Soares Lucas
cslucas at openjdk.org
Thu Aug 31 21:56:07 UTC 2023
> I believe the factory methods for AddPNode should be in the AddPNode class. The make_load / make_store methods in PhaseMacroExpand can be refactored to instead just use the "make" methods from Load/Store classes.
>
> Tested with tier1-3.
Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
Convert uses of AddPNode::make to new AddPNode
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15480/files
- new: https://git.openjdk.org/jdk/pull/15480/files/c4205846..943acfff
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15480&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15480&range=02-03
Stats: 42 lines in 8 files changed: 1 ins; 18 del; 23 mod
Patch: https://git.openjdk.org/jdk/pull/15480.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15480/head:pull/15480
PR: https://git.openjdk.org/jdk/pull/15480
More information about the shenandoah-dev
mailing list