RFR: Incorporate feedback from reviewers
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Jun 8 21:25:13 UTC 2023
On Thu, 8 Jun 2023 21:09:41 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> .jcheck/conf line 34:
>>
>>> 32: pattern=^([124-8][0-9]{6}): (\S.*)$
>>> 33:
>>> 34: [checks "problemlists"]
>>
>> I'd remove any changes to jcheck by adding it to your gitignore or something.
>
> Similarly, is the intention to remove the genshen-docs folder & its contents from the project repo entirely, or just let it lie there quietly. Not sure if there might be value in keeping it or if it has outlived its usefulness.
>
> In particular, the docs seem to include a design summary and a glossary of terms that might still have value (if suitably updated)?
OTOH may be the intention _is_ to change the jcheck for project repo to align it with upstream in which case ignore my first comment in thread.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/285#discussion_r1223561602
More information about the shenandoah-dev
mailing list