RFR: Incorporate feedback from reviewers [v2]

[William Kemper]

On Thu, 8 Jun 2023 21:22:51 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Similarly, is the intention to remove the genshen-docs folder & its contents from the project repo entirely, or just let it lie there quietly. Not sure if there might be value in keeping it or if it has outlived its usefulness. 
>> 
>> In particular, the docs seem to include a design summary and a glossary of terms that might still have value (if suitably updated)?
>
> OTOH may be the intention _is_ to change the jcheck for project repo to align it with upstream in which case ignore my first comment in thread.

I just didn't want to have to "redo"  the undo of these changes for the next PR. I think if those design docs are still useful, we ought to incorporate them in the JEP or as a comment in `shenandoahGeneration.hpp`?

We originally disabled the jcheck rule that required PR's to have a JBS ticket because we weren't really using JBS at the time, but I think the intention going forward is that we _are_ using JBS, so we should have the rule again.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/285#discussion_r1223627155