RFR: Use distinct "end of cycle" message for each Shenandoah pause [v2]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue May 2 23:24:52 UTC 2023
On Tue, 2 May 2023 23:04:03 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move region aging into op_final_roots
>
> src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp line 82:
>
>> 80:
>> 81: void VM_ShenandoahFinalRoots::doit() {
>> 82: ShenandoahGCPauseMark mark(_gc_id, SvcGCMarker::CONCURRENT);
>
> Why are we disabling the aging of regions? And why are we disabling the aging cycle?
In my initial review, I missed that this functionality has been moved to ShenandoahConcurrentGC::entry_final_roots()
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/270#discussion_r1183125829
More information about the shenandoah-dev
mailing list