RFR: Use distinct "end of cycle" message for each Shenandoah pause [v2]

[William Kemper]

On Tue, 2 May 2023 23:12:16 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp line 82:
>> 
>>> 80: 
>>> 81: void VM_ShenandoahFinalRoots::doit() {
>>> 82:   ShenandoahGCPauseMark mark(_gc_id, SvcGCMarker::CONCURRENT);
>> 
>> Why are we disabling the aging of regions?  And why are we disabling the aging cycle?
>
> In my initial review, I missed that this functionality has been moved to ShenandoahConcurrentGC::entry_final_roots()

I moved it into `ShenandoahConcurrentGC::op_final_roots` to fit the pattern of other phases (`VM_Operation_XYZ` and `entry_XYZ` should just have GC tracking boiler plate). Also, with this approach, we don't have to marshal the `is_aging_cycle` around.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/270#discussion_r1183127325