RFR: Use distinct "end of cycle" message for each Shenandoah pause [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Tue May 2 23:24:52 UTC 2023


On Tue, 2 May 2023 23:15:37 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> In my initial review, I missed that this functionality has been moved to ShenandoahConcurrentGC::entry_final_roots()
>
> I moved it into `ShenandoahConcurrentGC::op_final_roots` to fit the pattern of other phases (`VM_Operation_XYZ` and `entry_XYZ` should just have GC tracking boiler plate). Also, with this approach, we don't have to marshal the `is_aging_cycle` around.

Thanks for clarifying.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/270#discussion_r1183128107


More information about the shenandoah-dev mailing list