RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v4]

[Cesar Soares Lucas]

On Thu, 30 Nov 2023 09:24:12 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Fix merge
>>  - Catch up with master branch.
>>    
>>    Merge remote-tracking branch 'origin/master' into reuse-macroasm
>>  - Some inst_mark fixes; Catch up with master.
>>  - Catch up with changes on master
>>  - Reuse same C2_MacroAssembler object to emit instructions.
>
> src/hotspot/cpu/aarch64/aarch64.ad line 2829:
> 
>> 2827:   enc_class aarch64_enc_ldrsbw(iRegI dst, memory1 mem) %{
>> 2828:     Register dst_reg = as_Register($dst$$reg);
>> 2829:     loadStore(masm, &MacroAssembler::ldrsbw, dst_reg, $mem->opcode(),
> 
> The block of code should be auto-generated by `ad_encode.m4` file. 
> We'd better not edit these lines directly. Instead, we should update the m4 file accordingly.

Oops. I didn't see the comment there! Thank you for letting me know.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16484#discussion_r1411050332