RFR: 8318190: GenShen: Be less aggressive with triggers for old-gen has expanded [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Oct 17 21:35:01 UTC 2023


On Tue, 17 Oct 2023 15:37:36 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp line 38:
> 
>> 36:                             constraint)                                     \
>> 37:                                                                             \
>> 38:   product(double, ShenandoahGenerationalMinOldGenGrowthPercent,             \
> 
> I'd rather not include `Generational` in these property names - I think it just makes them too long and I don't think users will confuse them with non-generational settings.

I'll make that change.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/341#discussion_r1362811391


More information about the shenandoah-dev mailing list