RFR: 8318190: GenShen: Be less aggressive with triggers for old-gen has expanded [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Oct 17 23:27:22 UTC 2023


On Tue, 17 Oct 2023 15:35:41 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/shenandoahControlThread.hpp line 106:
> 
>> 104:   volatile GCMode _mode;
>> 105:   shenandoah_padding(3);
>> 106:   volatile size_t _consecutive_young;
> 
> This member would fit in better with `ShenandoahCollectorPolicy`, which gathers similar statistics via its `record` methods (`record_success_concurrent`, `record_success_old`, e.g.). We wouldn't need changes in `ShenandoahControlThread` in that approach.

Thanks.  Good suggestion.  I'm moving this into ShenandoahCollectorPolicy.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/341#discussion_r1362921259


More information about the shenandoah-dev mailing list