RFR: 8318190: GenShen: Be less aggressive with triggers for old-gen has expanded [v3]

[Kelvin Nilsen]

On Tue, 17 Oct 2023 15:41:30 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 519:
> 
>> 517:   }
>> 518: 
>> 519:   if (_growth_trigger) {
> 
> Could the trigger just evaluate the condition directly? It's not clear why we double check `_growth_trigger` condition instead of just checking once when trigger is evaluated?

Just to be sure: are you suggesting that before we raise the _growth_trigger, we should confirm that we are not doing mixed evacuations?  And then we don't have to recheck whether the trigger condition is still valid when we get to here?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/341#discussion_r1362925498