RFR: 8315044: GenShen: Verifier detects clean card should be dirty [v6]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Sep 5 19:06:51 UTC 2023


> When a Reference object is newly discovered, it is placed onto the worker's thread-local discovered list.  This sometimes results in a reference from an old object to a young object, requiring that the remembered set card-table entry be marked as dirty.  This patch causes the marking to be performed.

Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
 - Better abstraction from reviewer feedback
 - Use card_mark_barrier() method and ShenandoahCardBarrier tests
 - Replace is_generational with ShenandoahCardBarrier test
 - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
 - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
 - Also update card table when moving discovered References to global list
 - Fix whitespace
 - Mark card as dirty if discovered reference list has interesting pointer

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/314/files
  - new: https://git.openjdk.org/shenandoah/pull/314/files/2618ff3c..e9db1211

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=314&range=05
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=314&range=04-05

  Stats: 7883 lines in 280 files changed: 5634 ins; 933 del; 1316 mod
  Patch: https://git.openjdk.org/shenandoah/pull/314.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah.git pull/314/head:pull/314

PR: https://git.openjdk.org/shenandoah/pull/314


More information about the shenandoah-dev mailing list