RFR: 8315044: GenShen: Verifier detects clean card should be dirty [v6]

William Kemper wkemper at openjdk.org
Wed Sep 6 15:40:38 UTC 2023


On Tue, 5 Sep 2023 19:06:51 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> When a Reference object is newly discovered, it is placed onto the worker's thread-local discovered list.  This sometimes results in a reference from an old object to a young object, requiring that the remembered set card-table entry be marked as dirty.  This patch causes the marking to be performed.
>
> Kelvin Nilsen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
>  - Better abstraction from reviewer feedback
>  - Use card_mark_barrier() method and ShenandoahCardBarrier tests
>  - Replace is_generational with ShenandoahCardBarrier test
>  - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
>  - Merge remote-tracking branch 'origin/master' into ref-processor-updates-remembered-set
>  - Also update card table when moving discovered References to global list
>  - Fix whitespace
>  - Mark card as dirty if discovered reference list has interesting pointer

Marked as reviewed by wkemper (Committer).

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/314#pullrequestreview-1613659964


More information about the shenandoah-dev mailing list