RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v3]

[Aleksey Shipilev]

On Thu, 11 Apr 2024 18:09:08 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed shenandoah missed changes.
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2267:
> 
>> 2265:   char* start = (char*) _bitmap_region.start() + off;
>> 2266: 
>> 2267:   if (!os::commit_memory(start, len, false)) {
> 
> I think this should probably be `mtGC`.  @shipilev, you don't happen to know whether this should be accounted under the Java heap? Thank you.

This is bitmap slice, so it is not Java heap, it is `mtGC`. In the sister method, `uncommit_bitmap_slice`, we do the right thing: `mtGC`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1561459688