RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v3]

[Afshin Zafari]

On Thu, 11 Apr 2024 18:21:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2267:
>> 
>>> 2265:   char* start = (char*) _bitmap_region.start() + off;
>>> 2266: 
>>> 2267:   if (!os::commit_memory(start, len, false)) {
>> 
>> I think this should probably be `mtGC`.  @shipilev, you don't happen to know whether this should be accounted under the Java heap? Thank you.
>
> This is bitmap slice, so it is not Java heap, it is `mtGC`. In the sister method, `uncommit_bitmap_slice`, we do the right thing: `mtGC`.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1561641931