RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v3]

[Afshin Zafari]

On Thu, 11 Apr 2024 18:13:55 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed shenandoah missed changes.
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 460:
> 
>> 458:   assert(_reserved_regions != nullptr, "Sanity check");
>> 459: 
>> 460:   ReservedMemoryRegion  rgn(addr, size, NativeCallStack::empty_stack(), flag);
> 
> Instead, change the constructor so that it takes a flag?
> 
> ```c++
>   ReservedMemoryRegion(address base, size_t size, MEMFLAGS flag) :
>     VirtualMemoryRegion(base, size), _stack(NativeCallStack::empty_stack()), _flag(flag) { }
> 
> 
> Or does that break somewhere else?

Fixed. No problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1561653418