RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v4]

[Afshin Zafari]

On Fri, 12 Apr 2024 07:59:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments applied.
>
> src/hotspot/share/runtime/os.hpp line 521:
> 
>> 519:                            bool allow_exec = false, MEMFLAGS flags = mtNone);
>> 520:   static bool   unmap_memory(char *addr, size_t bytes);
>> 521:   static void   free_memory(char *addr, size_t bytes, size_t alignment_hint, MEMFLAGS flag);
> 
> While looking at this, I noticed a couple of odd things about this function. I think it should be revised and I opened https://bugs.openjdk.org/browse/JDK-8330144. The result of that revision will be that we don't need MEMFLAGS, nor do would we need the alignment hint. 
> 
> But leave the MEMFLAGS in for now. If I happen to push that change first, you can adapt the change, if you push first I'll manage.

OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1565997790