RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v4]

[Afshin Zafari]

On Fri, 12 Apr 2024 07:42:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments applied.
>
> src/hotspot/share/memory/metaspace/testHelpers.cpp line 81:
> 
>> 79:   if (reserve_limit > 0) {
>> 80:     // have reserve limit -> non-expandable context
>> 81:     _rs = ReservedSpace(reserve_limit * BytesPerWord, Metaspace::reserve_alignment(), os::vm_page_size(), mtTest);
> 
> mtMetaspace

Done

> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 112:
> 
>> 110: 
>> 111:   // Commit...
>> 112:   if (os::commit_memory((char*)p, word_size * BytesPerWord, !ExecMem, _rs.nmt_flag()) == false) {
> 
> just use mtMetaspace here, its easier

Done.

> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 191:
> 
>> 189: 
>> 190:   // Uncommit...
>> 191:   if (os::uncommit_memory((char*)p, word_size * BytesPerWord, !ExecMem, _rs.nmt_flag()) == false) {
> 
> mtMetaspace

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1566031812
PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1566032265
PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1566032016