RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v10]

[Afshin Zafari]

On Fri, 19 Apr 2024 06:37:41 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more improvements in style/alignments/adjustments.
>
> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 306:
> 
>> 304:     VirtualMemoryRegion(base, size), _stack(NativeCallStack::empty_stack()), _flag(mtNone) { }
>> 305: 
>> 306:   ReservedMemoryRegion(address base, size_t size, MEMFLAGS flag) :
> 
> (Commenting here because GitHub doesn't allow me to add comments to unchanged lines). I'd like to see a follow-up RFE that makes
> 
>   ReservedMemoryRegion(address base, size_t size) :
>     VirtualMemoryRegion(base, size), _stack(NativeCallStack::empty_stack()), _flag(mtNone) { }
> 
> a private constructor, so that it is only used for our find operations and never accidentally used for other code.

https://bugs.openjdk.org/browse/JDK-8330627 is created for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1572041557