RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v10]
Afshin Zafari
azafari at openjdk.org
Fri Apr 19 09:09:29 UTC 2024
On Fri, 19 Apr 2024 08:48:36 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> `reserve_large_pages_individually` has a local `flags` variable and
>> `allocate_pages_individually` has a `flags` param in their definitions. So, the `nmt_flag` is used to avoid confusing different flags while reading the code.
>> Other cases where there would be no ambiguity, the `nmt_flag` is renamed to `flag`.
>
> Could you instead rename the local 'flags' variable instead?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1572069037
More information about the shenandoah-dev
mailing list