RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[Thomas Stuefe]

On Mon, 22 Apr 2024 12:51:33 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed extra blank line.
>
> src/hotspot/share/memory/virtualspace.cpp line 45:
> 
>> 43: // Dummy constructor
>> 44: ReservedSpace::ReservedSpace() : _base(nullptr), _size(0), _noaccess_prefix(0),
>> 45:     _alignment(0), _fd_for_heap(-1), _special(false), _executable(false), _nmt_flag(mtNone) {
> 
> Isn't just `_flag` or `_memflag` sufficient as a name for `ReservedSpace`? We don' use `nmt_flag` anywhere else in the codebase.

Yes, I would keep consistency with existing code, and maybe later rename all in one followup change

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1575764827