RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[Afshin Zafari]

On Mon, 22 Apr 2024 12:43:43 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed extra blank line.
>
> src/hotspot/os/windows/os_windows.cpp line 5108:
> 
>> 5106: 
>> 5107:     base = (char*) virtualAlloc(addr, bytes, MEM_COMMIT | MEM_RESERVE,
>> 5108:                                 PAGE_READWRITE);
> 
> Why is this removed?

We found this call duplicated, since the `MemTracker::record_..._and_commit` is called inside the `os::map_memory` after `pd_map_memory` is called.
Here, the requested address is used, but there the result address is used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1575876476