RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[Afshin Zafari]

On Tue, 23 Apr 2024 06:12:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed extra blank line.
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1332:
> 
>> 1330:     // NMT: fix up the space tags
>> 1331:     MemTracker::record_virtual_memory_type(archive_space_rs.base(), mtClassShared);
>> 1332:     MemTracker::record_virtual_memory_type(class_space_rs.base(), mtClass);
> 
> I assumed these (and others) were removed because the `MemTracker` updates had been pushed down into `ReserveSpace` itself, but I can't find them there - what am I missing?

`archive_space_rs` and `class_space_rs` pass the MEMFLAGS to the `ReservedSpace` ctors a few lines above at 1272, 1319 and 1321.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1575884704