RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[David Holmes]

On Tue, 23 Apr 2024 08:46:42 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/cds/metaspaceShared.cpp line 1332:
>> 
>>> 1330:     // NMT: fix up the space tags
>>> 1331:     MemTracker::record_virtual_memory_type(archive_space_rs.base(), mtClassShared);
>>> 1332:     MemTracker::record_virtual_memory_type(class_space_rs.base(), mtClass);
>> 
>> I assumed these (and others) were removed because the `MemTracker` updates had been pushed down into `ReserveSpace` itself, but I can't find them there - what am I missing?
>
> `archive_space_rs` and `class_space_rs` pass the MEMFLAGS to the `ReservedSpace` ctors a few lines above at 1272, 1319 and 1321.

Yes I see the flags being passed to `ReservedSpace` but I don't see where `ReservedSpace` then calls `record_virtual_memory_type`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1577656637