RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v7]

[Stefan Karlsson]

On Tue, 23 Apr 2024 13:08:27 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> New info:
>> I added the check and it always failed, meaning that no uncommit flag matches with commit flag.
>> I will remove the mandatory flag from uncommit, but it hides the issue of non-matching commit-uncommit flags.
>
> Keeping the flag argument for `os::uncommit_memory` is important as it is equivalent to `reserve`:ing the memory. This makes future work easier, as we don't have to look at the region to figure out what flag it needs to be reserved as.

Is there a problem with looking at the region to figure out the flag of the currently committed memory region? On the surface that seems like a reasonable thing to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1577284106