RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v7]
Johan Sjölen
jsjolen at openjdk.org
Wed Apr 24 09:13:38 UTC 2024
On Wed, 24 Apr 2024 05:35:37 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Keeping the flag argument for `os::uncommit_memory` is important as it is equivalent to `reserve`:ing the memory. This makes future work easier, as we don't have to look at the region to figure out what flag it needs to be reserved as.
>
> Is there a problem with looking at the region to figure out the flag of the currently committed memory region? On the surface that seems like a reasonable thing to do.
It's not a problem per se, it's just nice not to have to :). Not a blocker, to be clear.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1577558517
More information about the shenandoah-dev
mailing list