RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered
William Kemper
wkemper at openjdk.org
Fri Aug 16 16:30:09 UTC 2024
On Fri, 16 Aug 2024 07:10:26 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
> De-templatize ShenandoahScanRemembered and ShenandoahCardCluster, based on Roman's review feedback at https://github.com/openjdk/jdk/pull/20395/files/46638cdef26fd25c290e6f63035ff5d2f1dc3bdb#r1718773835.
>
>
> **Testing:**
>
> - [x] GHA
> - [x] jtreg:tier1
> - [ ] codepipeline
> - [ ] SPECjbb
src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 228:
> 226: size_t card_index_for_addr(HeapWord *p) const;
> 227: HeapWord *addr_for_card_index(size_t card_index) const;
> 228: inline const CardValue* get_card_table_byte_map(bool write_table) const;
Should these smaller, non-templated functions remain inline?
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/472#discussion_r1720059179
More information about the shenandoah-dev
mailing list