RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Aug 16 18:54:13 UTC 2024
On Fri, 16 Aug 2024 16:24:37 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Leave the `inline` specifier intact against the smaller methods previously
>> declared inline.
>
> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 228:
>
>> 226: size_t card_index_for_addr(HeapWord *p) const;
>> 227: HeapWord *addr_for_card_index(size_t card_index) const;
>> 228: inline const CardValue* get_card_table_byte_map(bool write_table) const;
>
> Should these smaller, non-templated functions remain inline?
ok, let me revert the specifier back.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/472#discussion_r1720210912
More information about the shenandoah-dev
mailing list