RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered [v4]

Y. Srinivas Ramakrishna ysr at openjdk.org
Fri Aug 16 19:47:34 UTC 2024


> De-templatize ShenandoahScanRemembered and ShenandoahCardCluster, based on Roman's review feedback at https://github.com/openjdk/jdk/pull/20395/files/46638cdef26fd25c290e6f63035ff5d2f1dc3bdb#r1718773835.
> 
> 
> **Testing:**
> 
> - [x] GHA
> - [x] jtreg:tier1
> - [ ] codepipeline
> - [x] SPECjbb

Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into detemplatize
 - Leave get_card_table_byte_map() also inline like it was before; required
   moving definition into the hpp file as it was used by the tempated
   methods that needed it in multiple translation units presumably.
 - Leave the `inline` specifier intact against the smaller methods previously
   declared inline.
 - JDK-8338479 : GenShen: Detemplatize ShenandoahScanRemembered
   
   De-templatize ShenandoahScanRemembered and ShenandoahCardCluster

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/472/files
  - new: https://git.openjdk.org/shenandoah/pull/472/files/4ebd404a..0c19ca5f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=472&range=03
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=472&range=02-03

  Stats: 58 lines in 9 files changed: 3 ins; 45 del; 10 mod
  Patch: https://git.openjdk.org/shenandoah/pull/472.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah.git pull/472/head:pull/472

PR: https://git.openjdk.org/shenandoah/pull/472


More information about the shenandoah-dev mailing list