RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered [v4]

[Y. Srinivas Ramakrishna]

On Fri, 16 Aug 2024 19:47:34 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> De-templatize ShenandoahScanRemembered and ShenandoahCardCluster, based on Roman's review feedback at https://github.com/openjdk/jdk/pull/20395/files/46638cdef26fd25c290e6f63035ff5d2f1dc3bdb#r1718773835.
>> 
>> 
>> **Testing:**
>> 
>> - [x] GHA
>> - [x] jtreg:tier1
>> - [ ] codepipeline
>> - [x] SPECjbb
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into detemplatize
>  - Leave get_card_table_byte_map() also inline like it was before; required
>    moving definition into the hpp file as it was used by the tempated
>    methods that needed it in multiple translation units presumably.
>  - Leave the `inline` specifier intact against the smaller methods previously
>    declared inline.
>  - JDK-8338479 : GenShen: Detemplatize ShenandoahScanRemembered
>    
>    De-templatize ShenandoahScanRemembered and ShenandoahCardCluster

Running specjbb perf numbers and codepipeline again after syncing with latest changes in master. Will push later today once all is clear and no perf differences (don't expect any). Left the inline specifier intact on those methods as requested by William.

Thanks for your reviews!

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/472#issuecomment-2294133140