RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered [v3]

Y. Srinivas Ramakrishna ysr at openjdk.org
Fri Aug 16 20:41:02 UTC 2024


On Fri, 16 Aug 2024 19:55:10 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Leave get_card_table_byte_map() also inline like it was before; required
>>   moving definition into the hpp file as it was used by the tempated
>>   methods that needed it in multiple translation units presumably.
>
> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 1021:
> 
>> 1019:                                ShenandoahRegionChunkIterator* work_list,
>> 1020:                                bool is_concurrent);
>> 1021: 
> 
> Missed these; will restore these as well.

restored.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/472#discussion_r1720325366


More information about the shenandoah-dev mailing list