RFR: 8338479: GenShen: Detemplatize ShenandoahScanRemembered [v4]

[Y. Srinivas Ramakrishna]

On Fri, 16 Aug 2024 19:47:34 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> De-templatize ShenandoahScanRemembered and ShenandoahCardCluster, based on Roman's review feedback at https://github.com/openjdk/jdk/pull/20395/files/46638cdef26fd25c290e6f63035ff5d2f1dc3bdb#r1718773835.
>> 
>> 
>> **Testing:**
>> 
>> - [x] GHA
>> - [x] jtreg:tier1
>> - [ ] codepipeline
>> - [x] SPECjbb
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into detemplatize
>  - Leave get_card_table_byte_map() also inline like it was before; required
>    moving definition into the hpp file as it was used by the tempated
>    methods that needed it in multiple translation units presumably.
>  - Leave the `inline` specifier intact against the smaller methods previously
>    declared inline.
>  - JDK-8338479 : GenShen: Detemplatize ShenandoahScanRemembered
>    
>    De-templatize ShenandoahScanRemembered and ShenandoahCardCluster

src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 1021:

> 1019:   // Fills in assignment with next chunk of work and returns true iff there is more work.
> 1020:   // Otherwise, returns false.  This is multi-thread-safe.
> 1021:   inline bool next(struct ShenandoahRegionChunk *assignment);

Missed these; will restore these as well.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/472#discussion_r1720291557