RFR: 8338535: GenShen: some style improvements to source code implementationle [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Aug 19 21:49:06 UTC 2024
On Mon, 19 Aug 2024 21:34:18 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix name of zero_RegionData function
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 92:
>
>> 90: } RegionData;
>> 91:
>> 92: static inline void set_RegionData_region_and_garbage(RegionData& region_data, ShenandoahHeapRegion* region, size_t garbage) {
>
> Can these static functions just be instance methods? call sites would then be:
> ```C++
> region_data->set_region_and_garbage(region, garbage);
+1
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/475#discussion_r1722384459
More information about the shenandoah-dev
mailing list