RFR: 8338535: GenShen: some style improvements to source code implementation [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Aug 21 20:18:30 UTC 2024


On Mon, 19 Aug 2024 21:46:36 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 92:
>> 
>>> 90:   } RegionData;
>>> 91: 
>>> 92:   static inline void set_RegionData_region_and_garbage(RegionData& region_data, ShenandoahHeapRegion* region, size_t garbage) {
>> 
>> Can these static functions just be instance methods? call sites would then be:
>> ```C++
>> region_data->set_region_and_garbage(region, garbage);
>
> +1

very good suggestions.  it looks much better this way.  will make this change momentarily.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/475#discussion_r1725704053


More information about the shenandoah-dev mailing list