RFR: 8338528: GenShen: Cleanup shenandoahHeapRegion [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Aug 20 21:49:22 UTC 2024


On Tue, 20 Aug 2024 17:00:48 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> * Break up huge methods in shenandoahHeapRegion
>> * Clarify comments
>> * Change confusing method names
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify case for scanning all references within humongous object

src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp line 512:

> 510: }
> 511: 
> 512: void ShenandoahHeapRegion::oop_iterate_humongous_slice_dirty(OopIterateClosure* blk,

We're removing the dirty_only bool argument?  Was that always true for all callers?  Or always true if write table?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/476#discussion_r1724010879


More information about the shenandoah-dev mailing list