RFR: 8338528: GenShen: Cleanup shenandoahHeapRegion [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Aug 20 21:49:22 UTC 2024


On Tue, 20 Aug 2024 21:45:56 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify case for scanning all references within humongous object
>
> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp line 512:
> 
>> 510: }
>> 511: 
>> 512: void ShenandoahHeapRegion::oop_iterate_humongous_slice_dirty(OopIterateClosure* blk,
> 
> We're removing the dirty_only bool argument?  Was that always true for all callers?  Or always true if write table?

I see, I think.  You've introduced a new method to handle the not-dirty case.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/476#discussion_r1724011895


More information about the shenandoah-dev mailing list