RFR: 8338528: GenShen: Cleanup shenandoahHeapRegion [v2]

[William Kemper]

On Tue, 20 Aug 2024 21:46:57 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp line 512:
>> 
>>> 510: }
>>> 511: 
>>> 512: void ShenandoahHeapRegion::oop_iterate_humongous_slice_dirty(OopIterateClosure* blk,
>> 
>> We're removing the dirty_only bool argument?  Was that always true for all callers?  Or always true if write table?
>
> I see, I think.  You've introduced a new method to handle the not-dirty case.

The original method was split it into two. The code path that handles _all_ cards didn't actually even need to look at the card table. The call sites where `dirty_only == false` call this new method. The call sites where `dirty_only == true` call this `oop_iterate_humongous_slice_dirty`.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/476#discussion_r1724067551